gianm commented on code in PR #18193:
URL: https://github.com/apache/druid/pull/18193#discussion_r2182792097
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/EmbeddedIndexTaskTest.java:
##########
@@ -102,7 +102,12 @@ public void test_runIndexTask_forInlineDatasource()
start = start.plusDays(1);
}
- // Wait for segments to be queryable
+ // Wait for all segments to be loaded and queryable
Review Comment:
Discussed in #18196 that the approach there, while perhaps more robust is
also too complex and so we won't do it. IMO, the approach you have here is
still an improvement so we might as well do it. It would be even better to add
a new Broker metric so we can be sure the Broker saw the segments too, but that
can be done separately so this PR isn't changing too much stuff at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
