clintropolis commented on code in PR #18207:
URL: https://github.com/apache/druid/pull/18207#discussion_r2196669364


##########
embedded-tests/src/test/resources/data/json/wikipedia_1.json:
##########
@@ -0,0 +1,3 @@
+{"timestamp": "2013-08-31T01:02:33Z", "page": "Gypsy Danger", "language" : 
"en", "tags": ["t1", "t2"], "user" : "nuclear", "unpatrolled" : "true", 
"newPage" : "true", "robot": "false", "anonymous": "false", 
"namespace":"article", "continent":"North America", "country":"United States", 
"region":"Bay Area", "city":"San Francisco", "added": 57, "deleted": 200, 
"delta": -143}

Review Comment:
   drive by comment/nit: i know this isn't new, but imo we should fix the 
problem of referring to this dataset as 'wikipedia' because it is confusing 
with the quickstart wikipedia data which is also going to be used in some 
tests, and this stuff only has a vaguely similar schema, maybe `tiny-wikipedia` 
or something to indicate that its a very small dataset would help clear things 
up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to