clintropolis opened a new pull request, #18228: URL: https://github.com/apache/druid/pull/18228
Some improvements to the embedded test stuff from my experience writing test for #18176, which is a query oriented test. The primary change is a new `beforeStart` method on `EmbeddedResource` interface, which allows them to perform additional operations when starting up (with access to the `EmbeddedDruidCluster` at this point, so shared resources are available). I have added usage of this new functionality to clean up how druid service properties are set, specifically `EmbeddedDruidService` has a new `addBeforeStart` method that takes a function add to a list of things to call during its implementation of the new `beforeStart` method. With this, I've cleaned up the `getStartupProperties` method to just copy all the stuff from the map, and moved all of the previous logic into the `beforeStart` hooks (and the historical specific logic into the `EmbeddedHistorical`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
