kfaraz commented on code in PR #18207: URL: https://github.com/apache/druid/pull/18207#discussion_r2199891502
########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/EmbeddedIndexParallelTaskTest.java: ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.indexing; + +import org.apache.druid.indexer.report.IngestionStatsAndErrors; +import org.apache.druid.indexer.report.IngestionStatsAndErrorsTaskReport; +import org.apache.druid.indexer.report.TaskReport; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedClusterApis; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedHistorical; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.EmbeddedRouter; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; +import org.junit.jupiter.params.provider.MethodSource; + +import java.util.List; +import java.util.Map; +import java.util.Optional; + +/** + * Runs tasks of "index_parallel" type using Indexers. + */ +public class EmbeddedIndexParallelTaskTest extends EmbeddedClusterTestBase Review Comment: > wondering if we should still call these integration tests, since they really are basically, just using a bit different framework to run them than the other frameworks. Yeah, I don't mind calling a test, say `IndexTaskIntegrationTest` or even any other name really, as long as we follow a single scheme across all modules. (I would just prefer not to retain the existing nomencluture of `IT*Test` as it always felt redundant 😛 ). I personally liked the ring of `Embedded*Test` and it has the added advantage of denoting that the test uses an embedded cluster (along with the identification and segregation benefits that I mentioned above). Since it uses an entire cluster, the fact that it is an integration test rather than a plain unit test is also implied. This name also felt appropriate since the primary module is called `embedded-tests`. Let me know if you have any particular reservations against the current nomenclature or if you feel `*IntegrationTest` (or other similar names) would offer any specific cognitive advantage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
