capistrant commented on code in PR #18239:
URL: https://github.com/apache/druid/pull/18239#discussion_r2201319824


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java:
##########
@@ -295,6 +295,22 @@ public TaskStatus runTask(TaskToolbox toolbox)
   {
     try {
       taskConfig = toolbox.getConfig();
+      if (!taskConfig.isAllowHadoopTaskExecution()) {
+        String errorMsg = StringUtils.format(
+            "Hadoop tasks are deprecated and will be removed in a future 
release. "
+            + "Currently, they are not allowed to run on this cluster. If you 
wish to run them despite deprecation, "
+            + "please set [%s] to true.",
+            TaskConfig.ALLOW_HADOOP_TASK_EXECUTION_KEY
+        );
+        log.error(errorMsg);
+        toolbox.getTaskReportFileWriter().write(getId(), 
getTaskCompletionReports());
+        return TaskStatus.failure(getId(), errorMsg);
+      }
+      log.warn("Running deprecated index_hadoop task [%s]. "
+              + "Hadoop indexing framework is deprecated and will be removed 
in a future release. "
+              + "Please migrate to the new indexing framework.",

Review Comment:
   trusted autocomplete from copilot for this msg 😆 should have read it closer. 
"the new indexing framework" is not useful. Will update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to