clintropolis commented on PR #18219: URL: https://github.com/apache/druid/pull/18219#issuecomment-3063491936
> wonder why do we need the rowsCurrentlyInMemory and bytesCurrentlyInMemory check logic in appenderator? It looks like it's just checking the size change for a single InputRow, and this logic seems already covered in IncrementalIndex.canAppendRow() `rowsCurrentlyInMemory` and `bytesCurrentlyInMemory` are across all of the `Sink` an appenderator has, while `canAppendRow` is for a single partial in memory part of a `Sink`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
