kfaraz opened a new pull request, #18245:
URL: https://github.com/apache/druid/pull/18245
### Summary
- This patch migrates several indexing and compaction integration tests
(several of which have been flaking out a lot recently) to the embedded-tests
framework.
- Overall, this migration will save about __1 hr 30 mins__ of GitHub runner
time.
- The MiddleManager version of the integration tests has currently not been
ported as they are slower and currently not desirable in embedded tests
(because they launch child processes).
- The MM-based embedded-tests can be easily enabled at any point in the
future.
### Changes
- The new tests use SQL queries to verify results instead of native since
the SQL syntax is much more concise and makes for more readable unit tests. We
can add native queries later or in future tests that are migrated to this
framework.
- Add `TaskBuilder` utility to create `Task` objects using fluent syntax
- Add JSON data resource files to `embedded-tests`
### Test migrations
|Old test|New test|
|--------|---------|
|`ITPerfectRollupParallelIndexTest`|`EmbeddedIndexParallelTaskTest`|
|`ITBestEffortRollupParallelIndexTest`|`EmbeddedIndexParallelTaskTest`,
added as a new test parameter which uses dynamic partitioning|
|`ITAutoCompactionTest`|`EmbeddedAutoCompactionTest`|
|`ITAutoCompactionLockContentionTest`|`EmbeddedAutoCompactionUpgradeTest`|
|`ITAutoCompactionLockContentionTest`|`EmbeddedKafkaClusterMetricsTest`,
method `test_ingestClusterMetrics_compactionSkipsLockedIntervals()`|
|`ITCompactionTaskTest`|`EmbeddedCompactionTaskTest`|
|`ITCompactionSparseColumnTest`|`EmbeddedCompactionSparseColumnTest`|
|`ITOverlordResourceTest`|Already being verified in
`EmbeddedOverlordClientTest`|
|`ITOverlordResourceNotFoundTest`|Already being verified in
`EmbeddedOverlordClientTest`|
### New nested tests
- `EmbeddedCentralizedSchemaPublishFailureTest` for the group
`cds-task-schema-publish-disabled`
- `EmbeddedCentralizedSchemaMetadataQueryDisabledTest` for the group
`cds-coordinator-metadata-query-disabled`
### Test run times
|Test|Actual test time|Total time including setup|
|----|-------------|-----------------------------|
|`EmbeddedIndexParallelTaskTest`(indexer)|38 s|__38 s__ |
|`EmbeddedAutoCompactionTest` (indexer)|1 min 20 s|__1 min 20 s__|
|`EmbeddedCompactionSparseColumnTest` (indexer)|12 s|__12 s__|
|Standard `ITPerfectRollupParallelIndexTest`|10 min|15 min|
|Standard `ITPerfectRollupParallelIndexTest`<br/>(Indexer, shuffle deep
store test, only 1 config changed)|10 min|15 min|
|Standard `ITPerfectRollupParallelIndexTest`<br/>(MM, shuffle deep store
test, only 1 config changed)|10 min|15 min|
|Standard `ITBestEffortRollupParallelIndexTest`|2 min| NA(setup includes
other tests too) |
|Revised `ITBestEffortRollupParallelIndexTest`|4 min 10 s| " |
|Standard `ITAutoCompactionTest` (middle manager)|25 mins|"|
|Standard `ITAutoCompactionTest` (indexer)|15 mins|"|
|Standard `ITCompactionSparseColumnTest` (indexer)|2 min 10 s|"|
---
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
