kfaraz commented on code in PR #18249:
URL: https://github.com/apache/druid/pull/18249#discussion_r2206138156
##########
processing/src/test/java/org/apache/druid/java/util/metrics/StubServiceEmitter.java:
##########
@@ -68,15 +71,15 @@ public void emit(Event event)
*/
public List<Event> getEvents()
{
- return events;
+ return new ArrayList<>(events);
}
/**
* Gets all the metric events emitted since the previous {@link #flush()}.
*
* @return Map from metric name to list of events emitted for that metric.
*/
- public Map<String, List<ServiceMetricEventSnapshot>> getMetricEvents()
+ public Map<String, Queue<ServiceMetricEventSnapshot>> getMetricEvents()
{
return metricEvents;
Review Comment:
Nit: I guess we can later update this method to also return a map containing
read-only lists rather than the `Queue` or maybe just update the method to
accept a metric name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
