kgyrtkirk commented on PR #18087: URL: https://github.com/apache/druid/pull/18087#issuecomment-3078115310
Hey Frank! wanted to leave a message earlier...but I always got distracted/delayed/etc... I was experimenting with some stuff which was slightly related; I've reverted it as I didn't wanted to throw in something new in the middle of something else...then forgot to get back to it. my tries are [here](https://github.com/kgyrtkirk/druid/commit/31574b05c8acb7a86b08256d3b562d9a6b2a86c6) - it won't cover all next points... when I was thinking about this I was considering: * package related things together: * `name` of the config stuff * `summary` or something...in most cases the comment is actually this * `defaultValue` * `validation` logic - if there is any * other stuff which might make sense somewhere and should belong to the prop; like `category` * easy access to the typed api of the value - without a bunch of manually maintained methods * with possibly something like: `queryContext.getValue(Prop.class)` * using a full type they could be worked with better...and no more `QueryContexts` and other property pool-er classes to hold them as static fields - or questions "where this property was declared" * for the registry they could possibly be loaded thru injector * possibly later generate an `md` file from them for the site.... I think you were also thinking in the same direction - most likely more centered on the `sys` table as that was your main goal :) What do you think about creating full classes for every setting and using `getValue` that way? Changes to these are disruptive to other places (current changeset affect `107` files) as it may change the way props are read...which is like everywhere - so I think the most important would be to select how we want to change the property read pattern (or provide backward compatible way?) and change it only once -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
