kfaraz commented on code in PR #18272:
URL: https://github.com/apache/druid/pull/18272#discussion_r2213894481
##########
processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java:
##########
@@ -66,11 +66,11 @@ public void testDefaultQueryMetricsQuery()
.context(ImmutableMap.of("testKey", "testValue"))
.build();
queryMetrics.query(query);
- queryMetrics.reportQueryTime(0).emit(serviceEmitter);
// No way to verify this right now since DefaultQueryMetrics implements a
no-op for sqlQueryId(String) and queryId(String)
// This change is done to keep the code coverage tool happy by exercising
the implementation
queryMetrics.sqlQueryId("dummy");
queryMetrics.queryId("dummy");
+ queryMetrics.reportQueryTime(0).emit(serviceEmitter);
Review Comment:
Need to emit the event after all the dimensions are set. Otherwise, this
test would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
