GWphua commented on code in PR #18234:
URL: https://github.com/apache/druid/pull/18234#discussion_r2218075556
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java:
##########
@@ -266,11 +267,20 @@ protected Map<KafkaTopicPartition, Long>
getPartitionRecordLag()
}
if
(!latestSequenceFromStream.keySet().equals(highestCurrentOffsets.keySet())) {
- log.warn(
- "Kafka partitions[%s] do not match task partitions[%s]",
- latestSequenceFromStream.keySet(),
- highestCurrentOffsets.keySet()
- );
+ Set<KafkaTopicPartition> kafkaPartitions =
latestSequenceFromStream.keySet();
+ Set<KafkaTopicPartition> taskPartitions = highestCurrentOffsets.keySet();
+
+ List<Integer> missingTaskPartitions = Sets.difference(kafkaPartitions,
taskPartitions)
Review Comment:
This is what i was asking
[here](https://github.com/apache/druid/pull/18234#issuecomment-3061075435), I
was thinking that the chances of getting topic that does not match is low, so
we can write the partition number. However, I now agree that logging the topic
is better, so we do not miss out on any information, and avoid confusion on the
operator side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
