clintropolis commented on code in PR #18292:
URL: https://github.com/apache/druid/pull/18292#discussion_r2220007212
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -113,37 +113,6 @@ public static class PruneSpecsHolder
private final CompactionState lastCompactionState;
private final long size;
- /**
- * @deprecated use {@link #builder(SegmentId)} or {@link
#builder(DataSegment)} instead.
- */
- @Deprecated
- public DataSegment(
Review Comment:
do we intend to eventually remove the other `@Deprecated` constructor too? i
don't expect that in this PR since it is fixing a bug and the other one has
quite a lot more callers, just wondering.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -286,24 +287,24 @@ private DataSegmentsWithSchemas mergeAndPushSegments(
final List<String> metricNames =
Arrays.stream(dataSchema.getAggregators())
.map(AggregatorFactory::getName)
.collect(Collectors.toList());
+ SegmentId segmentId = SegmentId.of(
+ getDataSource(),
+ interval,
+ Preconditions.checkNotNull(AbstractBatchIndexTask.findVersion(
+ intervalToVersion,
+ interval
+ ), "version for interval[%s]", interval),
+ null
Review Comment:
nit: this just calls the version of `of` which takes `partitionNum` with a
`0` argument, it might be clearer to do that instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
