cecemei commented on code in PR #18328:
URL: https://github.com/apache/druid/pull/18328#discussion_r2240604739
##########
processing/src/test/java/org/apache/druid/segment/TestIndex.java:
##########
@@ -221,51 +231,52 @@ public class TestIndex
ComplexMetrics.registerSerde(HyperUniquesSerde.TYPE_NAME, new
HyperUniquesSerde());
}
- private static Supplier<IncrementalIndex> realtimeIndex = Suppliers.memoize(
+ private static Supplier<IncrementalIndex> rtIndex = Suppliers.memoize(
TestIndex::makeSampleNumericIncrementalIndex
);
- private static Supplier<IncrementalIndex>
realtimeIndexPartialSchemaLegacyStringDiscovery = Suppliers.memoize(
- () -> fromJsonResource(
+ // PROJECTIONS are defined on string dimensions, they can't be used with
this index
+ private static Supplier<IncrementalIndex>
rtPartialSchemaStringDiscoveryIndex = Suppliers.memoize(
+ () -> fromJsonResourceWithNoProjection(
SAMPLE_NUMERIC_JSON,
true,
DIMENSIONS_SPEC_PARTIAL_NO_STRINGS
)
);
- private static Supplier<IncrementalIndex> nonTimeOrderedRealtimeIndex =
Suppliers.memoize(
+ private static Supplier<IncrementalIndex> nonTimeOrderedRtIndex =
Suppliers.memoize(
() -> fromJsonResource(SAMPLE_NUMERIC_JSON, true,
DIMENSIONS_SPEC_NON_TIME_ORDERED)
);
- private static Supplier<IncrementalIndex>
nonTimeOrderedNoRollupRealtimeIndex = Suppliers.memoize(
+ private static Supplier<IncrementalIndex> nonTimeOrderedNoRollupRtIndex =
Suppliers.memoize(
() -> fromJsonResource(SAMPLE_NUMERIC_JSON, false,
DIMENSIONS_SPEC_NON_TIME_ORDERED)
);
- private static Supplier<IncrementalIndex> noRollupRealtimeIndex =
Suppliers.memoize(
+ private static Supplier<IncrementalIndex> noRollupRtIndex =
Suppliers.memoize(
() -> fromJsonResource(SAMPLE_NUMERIC_JSON, false, DIMENSIONS_SPEC)
);
- private static Supplier<IncrementalIndex> noBitmapRealtimeIndex =
Suppliers.memoize(
+ private static Supplier<IncrementalIndex> noBitmapRtIndex =
Suppliers.memoize(
() -> fromJsonResource(SAMPLE_NUMERIC_JSON, false,
DIMENSIONS_SPEC_NO_BITMAPS)
);
- private static Supplier<QueryableIndex> mmappedIndex = Suppliers.memoize(
+ private static Supplier<QueryableIndex> mMappedIndex = Suppliers.memoize(
Review Comment:
ah makes sense, although it seems like the second M with upper-case is used
more widely, maybe that's something needs to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
