cryptoe commented on code in PR #18356:
URL: https://github.com/apache/druid/pull/18356#discussion_r2250357847
##########
processing/src/main/java/org/apache/druid/java/util/metrics/cgroups/CpuSet.java:
##########
@@ -72,7 +72,7 @@ private int[] readCpuSetFile(String file)
output =
lines.stream().map(this::parseStringRangeToIntArray).findFirst().orElse(output);
}
catch (RuntimeException | IOException ex) {
- LOG.error(ex, "Unable to read %s", file);
+ LOG.noStackTrace().warn(ex, "Unable to read %s, these metrics will be
skipped", file);
Review Comment:
Nit: IMHO, it might be better to add all the `CPUS_FILE`,
`EFFECTIVE_CPUS_FILE` etc in an array and then replace `these` with the exact
metric name. That would help admins to figure out what happens with `CPUS_FILE`
since the cluster admin would most likely grep for the particular string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
