gianm commented on code in PR #18358: URL: https://github.com/apache/druid/pull/18358#discussion_r2259466626
########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthIndexingTest.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.auth; + +import com.fasterxml.jackson.core.type.TypeReference; +import org.apache.druid.rpc.RequestBuilder; +import org.apache.druid.security.basic.BasicSecurityDruidModule; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.indexing.IndexTaskTest; +import org.jboss.netty.handler.codec.http.HttpMethod; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.List; + +public class BasicAuthIndexingTest extends IndexTaskTest +{ + @Override + public EmbeddedDruidCluster createCluster() + { + return super + .createCluster() + .addExtension(BasicSecurityDruidModule.class) + .addCommonProperty("druid.auth.authenticatorChain", "[\"basic\"]") Review Comment: This set of properties is repeated; how about making it shared? It could be a resource, for example. ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthMsqTest.java: ########## @@ -17,69 +17,132 @@ * under the License. */ -package org.apache.druid.testsEx.auth; +package org.apache.druid.testing.embedded.auth; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; -import com.google.inject.Inject; +import org.apache.calcite.sql.type.SqlTypeName; import org.apache.druid.common.utils.IdUtils; +import org.apache.druid.data.input.impl.JsonInputFormat; +import org.apache.druid.data.input.impl.LocalInputSource; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.indexing.common.task.Task; import org.apache.druid.java.util.common.StringUtils; -import org.apache.druid.java.util.http.client.response.StatusResponseHolder; +import org.apache.druid.metadata.DefaultPasswordProvider; +import org.apache.druid.msq.guice.IndexerMemoryManagementModule; +import org.apache.druid.msq.guice.MSQDurableStorageModule; +import org.apache.druid.msq.guice.MSQExternalDataSourceModule; +import org.apache.druid.msq.guice.MSQIndexingModule; +import org.apache.druid.msq.guice.MSQSqlModule; +import org.apache.druid.msq.guice.SqlTaskModule; +import org.apache.druid.msq.indexing.LegacyMSQSpec; import org.apache.druid.msq.indexing.MSQControllerTask; +import org.apache.druid.msq.indexing.MSQTuningConfig; +import org.apache.druid.msq.indexing.destination.ExportMSQDestination; +import org.apache.druid.msq.kernel.WorkerAssignmentStrategy; +import org.apache.druid.query.Druids; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.query.http.SqlTaskStatus; +import org.apache.druid.security.basic.BasicSecurityDruidModule; +import org.apache.druid.security.basic.authentication.BasicHTTPEscalator; +import org.apache.druid.segment.column.ColumnType; +import org.apache.druid.segment.column.RowSignature; import org.apache.druid.server.security.Action; import org.apache.druid.server.security.Resource; import org.apache.druid.server.security.ResourceAction; -import org.apache.druid.sql.http.SqlQuery; +import org.apache.druid.sql.calcite.external.ExternalDataSource; +import org.apache.druid.sql.calcite.planner.ColumnMapping; +import org.apache.druid.sql.calcite.planner.ColumnMappings; +import org.apache.druid.sql.http.ResultFormat; import org.apache.druid.storage.local.LocalFileExportStorageProvider; import org.apache.druid.storage.s3.output.S3ExportStorageProvider; -import org.apache.druid.testing.clients.CoordinatorResourceTestClient; -import org.apache.druid.testing.clients.OverlordResourceTestClient; -import org.apache.druid.testing.clients.SecurityClient; -import org.apache.druid.testing.utils.DataLoaderHelper; -import org.apache.druid.testing.utils.MsqTestQueryHelper; -import org.apache.druid.tests.indexer.AbstractIndexerTest; -import org.apache.druid.testsEx.categories.Security; -import org.apache.druid.testsEx.config.DruidTestRunner; -import org.jboss.netty.handler.codec.http.HttpResponseStatus; -import org.junit.After; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; -import org.junit.experimental.categories.Category; -import org.junit.runner.RunWith; - -import java.io.IOException; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.EmbeddedServiceClient; +import org.apache.druid.testing.embedded.indexing.Resources; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.apache.druid.testing.embedded.msq.MsqExportDirectory; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.File; import java.util.List; -import java.util.concurrent.ExecutionException; +import java.util.Map; -@RunWith(DruidTestRunner.class) -@Category(Security.class) -public class ITSecurityBasicQuery +public class BasicAuthMsqTest extends EmbeddedClusterTestBase { - @Inject - private MsqTestQueryHelper msqHelper; - - @Inject - private DataLoaderHelper dataLoaderHelper; - - @Inject - private CoordinatorResourceTestClient coordinatorClient; - @Inject - private SecurityClient securityClient; - @Inject - private OverlordResourceTestClient overlordResourceTestClient; - public static final String USER_1 = "user1"; public static final String ROLE_1 = "role1"; public static final String USER_1_PASSWORD = "password1"; - private static final String EXPORT_TASK = "/indexer/export_task.json"; // Time in ms to sleep after updating role permissions in each test. This intends to give the // underlying test cluster enough time to sync permissions and be ready when test execution starts. - private static final int SYNC_SLEEP = 10000; + private static final int SYNC_SLEEP = 500; + + private SecurityClient securityClient; + private EmbeddedServiceClient userClient; + + private final EmbeddedOverlord overlord = new EmbeddedOverlord(); + private final EmbeddedIndexer indexer = new EmbeddedIndexer() + .setServerMemory(400_000_000) + .addProperty("druid.worker.capacity", "2"); + private final MsqExportDirectory exportDirectory = new MsqExportDirectory(); Review Comment: Mostly in class names `MSQ` is fully capitalized. ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthMsqTest.java: ########## @@ -17,69 +17,132 @@ * under the License. */ -package org.apache.druid.testsEx.auth; +package org.apache.druid.testing.embedded.auth; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; -import com.google.inject.Inject; +import org.apache.calcite.sql.type.SqlTypeName; import org.apache.druid.common.utils.IdUtils; +import org.apache.druid.data.input.impl.JsonInputFormat; +import org.apache.druid.data.input.impl.LocalInputSource; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.indexing.common.task.Task; import org.apache.druid.java.util.common.StringUtils; -import org.apache.druid.java.util.http.client.response.StatusResponseHolder; +import org.apache.druid.metadata.DefaultPasswordProvider; +import org.apache.druid.msq.guice.IndexerMemoryManagementModule; +import org.apache.druid.msq.guice.MSQDurableStorageModule; +import org.apache.druid.msq.guice.MSQExternalDataSourceModule; +import org.apache.druid.msq.guice.MSQIndexingModule; +import org.apache.druid.msq.guice.MSQSqlModule; +import org.apache.druid.msq.guice.SqlTaskModule; +import org.apache.druid.msq.indexing.LegacyMSQSpec; import org.apache.druid.msq.indexing.MSQControllerTask; +import org.apache.druid.msq.indexing.MSQTuningConfig; +import org.apache.druid.msq.indexing.destination.ExportMSQDestination; +import org.apache.druid.msq.kernel.WorkerAssignmentStrategy; +import org.apache.druid.query.Druids; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.query.http.SqlTaskStatus; +import org.apache.druid.security.basic.BasicSecurityDruidModule; +import org.apache.druid.security.basic.authentication.BasicHTTPEscalator; +import org.apache.druid.segment.column.ColumnType; +import org.apache.druid.segment.column.RowSignature; import org.apache.druid.server.security.Action; import org.apache.druid.server.security.Resource; import org.apache.druid.server.security.ResourceAction; -import org.apache.druid.sql.http.SqlQuery; +import org.apache.druid.sql.calcite.external.ExternalDataSource; +import org.apache.druid.sql.calcite.planner.ColumnMapping; +import org.apache.druid.sql.calcite.planner.ColumnMappings; +import org.apache.druid.sql.http.ResultFormat; import org.apache.druid.storage.local.LocalFileExportStorageProvider; import org.apache.druid.storage.s3.output.S3ExportStorageProvider; -import org.apache.druid.testing.clients.CoordinatorResourceTestClient; -import org.apache.druid.testing.clients.OverlordResourceTestClient; -import org.apache.druid.testing.clients.SecurityClient; -import org.apache.druid.testing.utils.DataLoaderHelper; -import org.apache.druid.testing.utils.MsqTestQueryHelper; -import org.apache.druid.tests.indexer.AbstractIndexerTest; -import org.apache.druid.testsEx.categories.Security; -import org.apache.druid.testsEx.config.DruidTestRunner; -import org.jboss.netty.handler.codec.http.HttpResponseStatus; -import org.junit.After; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; -import org.junit.experimental.categories.Category; -import org.junit.runner.RunWith; - -import java.io.IOException; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.EmbeddedServiceClient; +import org.apache.druid.testing.embedded.indexing.Resources; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.apache.druid.testing.embedded.msq.MsqExportDirectory; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.File; import java.util.List; -import java.util.concurrent.ExecutionException; +import java.util.Map; -@RunWith(DruidTestRunner.class) -@Category(Security.class) -public class ITSecurityBasicQuery +public class BasicAuthMsqTest extends EmbeddedClusterTestBase { - @Inject - private MsqTestQueryHelper msqHelper; - - @Inject - private DataLoaderHelper dataLoaderHelper; - - @Inject - private CoordinatorResourceTestClient coordinatorClient; - @Inject - private SecurityClient securityClient; - @Inject - private OverlordResourceTestClient overlordResourceTestClient; - public static final String USER_1 = "user1"; public static final String ROLE_1 = "role1"; public static final String USER_1_PASSWORD = "password1"; - private static final String EXPORT_TASK = "/indexer/export_task.json"; // Time in ms to sleep after updating role permissions in each test. This intends to give the // underlying test cluster enough time to sync permissions and be ready when test execution starts. - private static final int SYNC_SLEEP = 10000; + private static final int SYNC_SLEEP = 500; Review Comment: I see the sleep is shorter now, but could it be made unnecessary? 500ms also seems dangerously short for a sleep that is actually required for some reason. It's short enough that some random slowness on the test runner will cause a test to flake. ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthMsqTest.java: ########## @@ -17,69 +17,132 @@ * under the License. */ -package org.apache.druid.testsEx.auth; +package org.apache.druid.testing.embedded.auth; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; -import com.google.inject.Inject; +import org.apache.calcite.sql.type.SqlTypeName; import org.apache.druid.common.utils.IdUtils; +import org.apache.druid.data.input.impl.JsonInputFormat; +import org.apache.druid.data.input.impl.LocalInputSource; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.indexing.common.task.Task; import org.apache.druid.java.util.common.StringUtils; -import org.apache.druid.java.util.http.client.response.StatusResponseHolder; +import org.apache.druid.metadata.DefaultPasswordProvider; +import org.apache.druid.msq.guice.IndexerMemoryManagementModule; +import org.apache.druid.msq.guice.MSQDurableStorageModule; +import org.apache.druid.msq.guice.MSQExternalDataSourceModule; +import org.apache.druid.msq.guice.MSQIndexingModule; +import org.apache.druid.msq.guice.MSQSqlModule; +import org.apache.druid.msq.guice.SqlTaskModule; +import org.apache.druid.msq.indexing.LegacyMSQSpec; import org.apache.druid.msq.indexing.MSQControllerTask; +import org.apache.druid.msq.indexing.MSQTuningConfig; +import org.apache.druid.msq.indexing.destination.ExportMSQDestination; +import org.apache.druid.msq.kernel.WorkerAssignmentStrategy; +import org.apache.druid.query.Druids; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.query.http.SqlTaskStatus; +import org.apache.druid.security.basic.BasicSecurityDruidModule; +import org.apache.druid.security.basic.authentication.BasicHTTPEscalator; +import org.apache.druid.segment.column.ColumnType; +import org.apache.druid.segment.column.RowSignature; import org.apache.druid.server.security.Action; import org.apache.druid.server.security.Resource; import org.apache.druid.server.security.ResourceAction; -import org.apache.druid.sql.http.SqlQuery; +import org.apache.druid.sql.calcite.external.ExternalDataSource; +import org.apache.druid.sql.calcite.planner.ColumnMapping; +import org.apache.druid.sql.calcite.planner.ColumnMappings; +import org.apache.druid.sql.http.ResultFormat; import org.apache.druid.storage.local.LocalFileExportStorageProvider; import org.apache.druid.storage.s3.output.S3ExportStorageProvider; -import org.apache.druid.testing.clients.CoordinatorResourceTestClient; -import org.apache.druid.testing.clients.OverlordResourceTestClient; -import org.apache.druid.testing.clients.SecurityClient; -import org.apache.druid.testing.utils.DataLoaderHelper; -import org.apache.druid.testing.utils.MsqTestQueryHelper; -import org.apache.druid.tests.indexer.AbstractIndexerTest; -import org.apache.druid.testsEx.categories.Security; -import org.apache.druid.testsEx.config.DruidTestRunner; -import org.jboss.netty.handler.codec.http.HttpResponseStatus; -import org.junit.After; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; -import org.junit.experimental.categories.Category; -import org.junit.runner.RunWith; - -import java.io.IOException; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.EmbeddedServiceClient; +import org.apache.druid.testing.embedded.indexing.Resources; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.apache.druid.testing.embedded.msq.MsqExportDirectory; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.File; import java.util.List; -import java.util.concurrent.ExecutionException; +import java.util.Map; -@RunWith(DruidTestRunner.class) -@Category(Security.class) -public class ITSecurityBasicQuery +public class BasicAuthMsqTest extends EmbeddedClusterTestBase { - @Inject - private MsqTestQueryHelper msqHelper; - - @Inject - private DataLoaderHelper dataLoaderHelper; - - @Inject - private CoordinatorResourceTestClient coordinatorClient; - @Inject - private SecurityClient securityClient; - @Inject - private OverlordResourceTestClient overlordResourceTestClient; - public static final String USER_1 = "user1"; public static final String ROLE_1 = "role1"; public static final String USER_1_PASSWORD = "password1"; - private static final String EXPORT_TASK = "/indexer/export_task.json"; // Time in ms to sleep after updating role permissions in each test. This intends to give the // underlying test cluster enough time to sync permissions and be ready when test execution starts. - private static final int SYNC_SLEEP = 10000; + private static final int SYNC_SLEEP = 500; + + private SecurityClient securityClient; + private EmbeddedServiceClient userClient; + + private final EmbeddedOverlord overlord = new EmbeddedOverlord(); + private final EmbeddedIndexer indexer = new EmbeddedIndexer() + .setServerMemory(400_000_000) Review Comment: It's helpful to have comments whenever overrides are set ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/SecurityClient.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.auth; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.rpc.RequestBuilder; +import org.apache.druid.server.security.ResourceAction; +import org.apache.druid.testing.embedded.EmbeddedServiceClient; +import org.jboss.netty.handler.codec.http.HttpMethod; + +import java.util.List; +import java.util.Map; +import java.util.function.Function; + +/** + * Client to call various basic auth APIs on the Coordinator. Review Comment: I don't understand this suggestion. ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthMsqTest.java: ########## @@ -334,18 +382,109 @@ public void testExportTaskSubmitOverlordWithoutPermission() throws Exception ); securityClient.setPermissionsToRole(ROLE_1, permissions); - // Allow permissions sync across cluster to avoid flakes - Thread.sleep(SYNC_SLEEP); + waitForPermissionsToSync(); + + final String taskId = IdUtils.getRandomId(); + MatcherAssert.assertThat( + Assertions.assertThrows( + Exception.class, + () -> userClient.onLeaderOverlord(o -> o.runTask(taskId, createExportTask(taskId))) + ), + ExceptionMatcher.of(Exception.class).expectMessageContains("403 Forbidden") + ); + } - String task = createTaskString(); - StatusResponseHolder statusResponseHolder = overlordResourceTestClient.submitTaskAndReturnStatusWithAuth(task, USER_1, USER_1_PASSWORD); - Assert.assertEquals(HttpResponseStatus.FORBIDDEN, statusResponseHolder.getStatus()); + private Task createExportTask(String taskId) Review Comment: The direct creation of the controller task is super verbose and a little brittle: this isn't meant to be a reliable Java API and using it creates coupling between this test and the main code. How about going through SQL instead? ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/auth/BasicAuthMsqTest.java: ########## @@ -17,69 +17,132 @@ * under the License. */ -package org.apache.druid.testsEx.auth; +package org.apache.druid.testing.embedded.auth; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; -import com.google.inject.Inject; +import org.apache.calcite.sql.type.SqlTypeName; import org.apache.druid.common.utils.IdUtils; +import org.apache.druid.data.input.impl.JsonInputFormat; +import org.apache.druid.data.input.impl.LocalInputSource; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.indexing.common.task.Task; import org.apache.druid.java.util.common.StringUtils; -import org.apache.druid.java.util.http.client.response.StatusResponseHolder; +import org.apache.druid.metadata.DefaultPasswordProvider; +import org.apache.druid.msq.guice.IndexerMemoryManagementModule; +import org.apache.druid.msq.guice.MSQDurableStorageModule; +import org.apache.druid.msq.guice.MSQExternalDataSourceModule; +import org.apache.druid.msq.guice.MSQIndexingModule; +import org.apache.druid.msq.guice.MSQSqlModule; +import org.apache.druid.msq.guice.SqlTaskModule; +import org.apache.druid.msq.indexing.LegacyMSQSpec; import org.apache.druid.msq.indexing.MSQControllerTask; +import org.apache.druid.msq.indexing.MSQTuningConfig; +import org.apache.druid.msq.indexing.destination.ExportMSQDestination; +import org.apache.druid.msq.kernel.WorkerAssignmentStrategy; +import org.apache.druid.query.Druids; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.query.http.SqlTaskStatus; +import org.apache.druid.security.basic.BasicSecurityDruidModule; +import org.apache.druid.security.basic.authentication.BasicHTTPEscalator; +import org.apache.druid.segment.column.ColumnType; +import org.apache.druid.segment.column.RowSignature; import org.apache.druid.server.security.Action; import org.apache.druid.server.security.Resource; import org.apache.druid.server.security.ResourceAction; -import org.apache.druid.sql.http.SqlQuery; +import org.apache.druid.sql.calcite.external.ExternalDataSource; +import org.apache.druid.sql.calcite.planner.ColumnMapping; +import org.apache.druid.sql.calcite.planner.ColumnMappings; +import org.apache.druid.sql.http.ResultFormat; import org.apache.druid.storage.local.LocalFileExportStorageProvider; import org.apache.druid.storage.s3.output.S3ExportStorageProvider; -import org.apache.druid.testing.clients.CoordinatorResourceTestClient; -import org.apache.druid.testing.clients.OverlordResourceTestClient; -import org.apache.druid.testing.clients.SecurityClient; -import org.apache.druid.testing.utils.DataLoaderHelper; -import org.apache.druid.testing.utils.MsqTestQueryHelper; -import org.apache.druid.tests.indexer.AbstractIndexerTest; -import org.apache.druid.testsEx.categories.Security; -import org.apache.druid.testsEx.config.DruidTestRunner; -import org.jboss.netty.handler.codec.http.HttpResponseStatus; -import org.junit.After; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; -import org.junit.experimental.categories.Category; -import org.junit.runner.RunWith; - -import java.io.IOException; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.EmbeddedServiceClient; +import org.apache.druid.testing.embedded.indexing.Resources; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.apache.druid.testing.embedded.msq.MsqExportDirectory; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.File; import java.util.List; -import java.util.concurrent.ExecutionException; +import java.util.Map; -@RunWith(DruidTestRunner.class) -@Category(Security.class) -public class ITSecurityBasicQuery +public class BasicAuthMsqTest extends EmbeddedClusterTestBase Review Comment: Mostly in class names `MSQ` is fully capitalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
