maytasm commented on PR #12891: URL: https://github.com/apache/druid/pull/12891#issuecomment-3221275885
> It might have been so because one could switch back to zk based segment announcements without waiting for all the segments to be announced on zk first. Otherwise, if one wants to switch back to http, they would have to first set this flag, wait for segment announcements to be available on zookeeper and then switch back the announcement mechanism to zk. > > Given that http based mechanism has been the de-facto one for a while and is very stable, we could indeed consider switching the default to `true`. I have seen some cases where huge number of watches in ZooKeeper is causing performance issue. While there are improvements like https://github.com/apache/druid/pull/17482, I wonder if just switching this to `true` will be an easy win. I feel that most people are already using http segment discovery (it has been default since v25) but doesn't know about the existence of this flag. Hence, maybe switching the default of this flag to `true` will be beneficial. I can raise a PR to switch the default to `true` unless there is any concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
