jamangstangs opened a new pull request, #18447:
URL: https://github.com/apache/druid/pull/18447

   ### Description
   Based on the changes in https://github.com/apache/druid/pull/13795,
   
   Currently, according to that PR, DRUID_ADDITIONAL_CLASSPATH is only applied 
to processes started via druid.sh. In the case of ingestion tasks launched as 
Kubernetes jobs through mmless mode, the additional configuration is not 
applied.
   
   For example, when performing Hadoop-based ingestion or using an HDFS 
inputSource, these files still need to be read. However, since the start script 
is peon.sh rather than druid.sh, the same configuration cannot be guaranteed.
   
   Therefore, the change ensures that the same classpath is also applied in 
peon.sh, allowing the necessary XML files to be added via the same environment 
variable for Peon.
   
   ---
   #### Release note
   Previously, it was possible to specify additional configuration to be 
mounted to _common via an environment variable, but this only applied to the 
Druid process. This change extends the behavior so that the same configuration 
is also applied to ingestion tasks submitted as Kubernetes jobs (mm-less mode), 
ensuring consistency across all task types.
   
   ---
   This PR has:
   
   - [ ] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to