kfaraz commented on code in PR #18470:
URL: https://github.com/apache/druid/pull/18470#discussion_r2318707256
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentBootstrapper.java:
##########
@@ -195,7 +195,7 @@ private void loadSegmentsOnStartup() throws IOException
final int numSegments = segmentsOnStartup.size();
final CountDownLatch latch = new CountDownLatch(numSegments);
final AtomicInteger counter = new AtomicInteger(0);
- final CopyOnWriteArrayList<DataSegment> failedSegments = new
CopyOnWriteArrayList<>();
+ final ConcurrentLinkedQueue<DataSegment> failedSegments = new
ConcurrentLinkedQueue<>();
Review Comment:
Yeah, I am okay either way too. Just wanted to understand if it is really
required to be thread safe.
By the way, why would it get converted to an array list in this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
