GWphua commented on PR #18477: URL: https://github.com/apache/druid/pull/18477#issuecomment-3253036874
Hi @kfaraz Since the benchmark samples involving period show a similar result now, I have replaced the benchmark with new fallback samples, all of which uses non-period in start/end (e.g. without millis specified) When calling deserialization with the optimized method, we should try our best to not use intervals of this format, else risking the below performance: 1. `"2022-01-01T00:00:00Z/2022-01-02T00:00:00Z"` 2. `"2022-01-01/2022-01-02"` Benchmark results are as shown: ``` Benchmark (numValues) Mode Cnt Score Error Units JodaIntervalDeserializationBenchmark.deserializeLegacyFallback 20000 avgt 19.085 ms/op JodaIntervalDeserializationBenchmark.deserializeOptimizedFallback 20000 avgt 33.561 ms/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
