kfaraz commented on code in PR #18483:
URL: https://github.com/apache/druid/pull/18483#discussion_r2326634806


##########
server/src/test/java/org/apache/druid/server/metrics/LatchableEmitter.java:
##########
@@ -129,15 +129,16 @@ public void waitForEvent(Predicate<Event> condition, long 
timeoutMillis)
   }
 
   /**
-   * Wait indefinitely until a metric event that matches the given condition 
is emitted.
+   * Wait until a metric event that matches the given condition is emitted.
+   * Uses a default timeout of 10 seconds.
    */
   public ServiceMetricEvent waitForEvent(UnaryOperator<EventMatcher> condition)
   {
     final EventMatcher matcher = condition.apply(new EventMatcher());
     waitForEvent(
         event -> event instanceof ServiceMetricEvent
                  && matcher.test((ServiceMetricEvent) event),
-        -1
+        10_000

Review Comment:
   ```suggestion
           20_000
   ```



##########
server/src/test/java/org/apache/druid/server/metrics/LatchableEmitter.java:
##########
@@ -129,15 +129,16 @@ public void waitForEvent(Predicate<Event> condition, long 
timeoutMillis)
   }
 
   /**
-   * Wait indefinitely until a metric event that matches the given condition 
is emitted.
+   * Wait until a metric event that matches the given condition is emitted.
+   * Uses a default timeout of 10 seconds.

Review Comment:
   ```suggestion
      * Uses a default timeout of 20 seconds.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to