clintropolis commented on code in PR #18507:
URL: https://github.com/apache/druid/pull/18507#discussion_r2335135511
##########
processing/src/main/java/org/apache/druid/math/expr/vector/ExprEvalBindingVector.java:
##########
@@ -133,9 +136,42 @@ public Object[] getObjectVector()
objects[i] = values[i];
}
}
- return objects;
+ } else {
+ objects = bindings.getObjectVector(bindingName);
+ }
+ return objects;
+ }
+
+ @Override
+ public boolean elementAsBoolean(int index)
Review Comment:
i thought about this, but i wasn't sure it seemed better since we would have
to loop over every value in the vector to make the `boolean[]`, and then again
loop over all of the condition booleans array to then build the vector match,
which seemed worse, but admittedly i didn't measure it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
