github-advanced-security[bot] commented on code in PR #18541:
URL: https://github.com/apache/druid/pull/18541#discussion_r2354283937
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -1692,6 +1702,23 @@
}
}
+ @Override
+ int estimatedKeySize(RowBasedKey key)
+ {
+ Object[] obj = key.getKey();
+ int size = 0;
+ for (Object o : obj) {
+ if (o instanceof String) {
+ size += estimateStringKeySize((String) o);
Review Comment:
## Implicit narrowing conversion in compound assignment
Implicit cast of source type long to narrower destination type [int](1).
[Show more
details](https://github.com/apache/druid/security/code-scanning/10335)
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -1692,6 +1702,23 @@
}
}
+ @Override
+ int estimatedKeySize(RowBasedKey key)
+ {
+ Object[] obj = key.getKey();
+ int size = 0;
+ for (Object o : obj) {
+ if (o instanceof String) {
+ size += estimateStringKeySize((String) o);
+ } else if (o != null) {
+ size += estimateStringKeySize(String.valueOf(o));
Review Comment:
## Implicit narrowing conversion in compound assignment
Implicit cast of source type long to narrower destination type [int](1).
[Show more
details](https://github.com/apache/druid/security/code-scanning/10336)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
