leventov commented on a change in pull request #7067: Made IntelliJ Inspection
"Iteration over keySet() could be replaced with entrySet()" a error & Fixed the
violations
URL: https://github.com/apache/incubator-druid/pull/7067#discussion_r262236612
##########
File path:
extensions-contrib/materialized-view-selection/src/main/java/org/apache/druid/query/materializedview/DataSourceOptimizerMonitor.java
##########
@@ -50,15 +52,15 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.build("/materialized/view/query/hitRate",
stat.getHitRate()));
emitter.emit(builder.build("/materialized/view/select/avgCostMS",
stat.getOptimizerCost()));
Map<String, Long> derivativesStats = stat.getDerivativesHitCount();
- for (String derivative : derivativesStats.keySet()) {
- builder.setDimension("derivative", derivative);
-
emitter.emit(builder.build("/materialized/view/derivative/numSelected",
derivativesStats.get(derivative)));
+ for (Map.Entry<String, Long> entry : derivativesStats.entrySet()) {
+ builder.setDimension("derivative", entry.getKey());
+
emitter.emit(builder.build("/materialized/view/derivative/numSelected",
derivativesStats.get(entry.getKey())));
}
final ServiceMetricEvent.Builder builder2 = new
ServiceMetricEvent.Builder();
builder2.setDimension("dataSource", stat.getBase());
- for (Set<String> fields : stat.getMissFields().keySet()) {
- builder2.setDimension("fields", fields.toString());
- emitter.emit(builder2.build("/materialized/view/missNum",
stat.getMissFields().get(fields).get()));
+ for (Map.Entry<Set<String>, AtomicLong> fields :
stat.getMissFields().entrySet()) {
Review comment:
Change the variable name to `e` or `entry`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
