kfaraz commented on code in PR #18567:
URL: https://github.com/apache/druid/pull/18567#discussion_r2373993661
##########
processing/src/main/java/org/apache/druid/math/expr/vector/FunctionErrorReportingExprVectorProcessor.java:
##########
@@ -57,7 +58,7 @@ public ExprEvalVector<T> evalVector(Expr.VectorInputBinding
bindings)
.ofCategory(DruidException.Category.INVALID_INPUT)
.build(e, "Function[%s] encountered exception: %s",
functionName, e.getMessage());
}
- catch (DruidException e) {
+ catch (DruidException | IAE e) {
Review Comment:
I think it might be better to catch the IAE and convert it to a
DruidException of type INVALID_INPUT instead, as it contains richer info for
sending over the wire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
