clintropolis commented on code in PR #17762:
URL: https://github.com/apache/druid/pull/17762#discussion_r2377711011
##########
processing/src/main/java/org/apache/druid/segment/DefaultColumnFormatConfig.java:
##########
@@ -69,17 +77,30 @@ private static void
validateMultiValueHandlingMode(@Nullable String stringMultiV
@JsonProperty("stringMultiValueHandlingMode")
private final String stringMultiValueHandlingMode;
+ @Nullable
+ @JsonProperty
+ private final NestedCommonFormatColumnFormatSpec nestedColumnFormatSpec;
+
@JsonCreator
public DefaultColumnFormatConfig(
+ @JsonProperty("stringMultiValueHandlingMode") @Nullable String
stringMultiValueHandlingMode,
@JsonProperty("nestedColumnFormatVersion") @Nullable Integer
nestedColumnFormatVersion,
- @JsonProperty("stringMultiValueHandlingMode") @Nullable String
stringMultiValueHandlingMode
+ @JsonProperty("nestedColumnFormatSpec") @Nullable
NestedCommonFormatColumnFormatSpec nestedColumnFormatSpec
Review Comment:
overhauled PR to allow defining system default `IndexSpec`, and all fields
now default to `null`. `IndexSpec` has a similar `getEffectiveSpec` which
merges to fill out properties in order of priority job indexSpec > system
indexSpec > hard coded defaults. This effectiveIndex spec is then what is used
to pass to `getEffectiveSpec` of column specs at segment creation time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
