gianm commented on code in PR #18509: URL: https://github.com/apache/druid/pull/18509#discussion_r2377240258
########## quidem-ut/src/test/quidem/org.apache.druid.quidem.QTest/qaJsonCols/funcs_and_sql_func_json_value.03.msq.iq: ########## @@ -1,5 +1,5 @@ !set useApproximateCountDistinct false -!use druidtest://?componentSupplier=StandardMSQComponentSupplier&datasets=sql/src/test/quidem/qatests/qaJsonCols/funcs_and_sql +!use druidtest://?componentSupplier=StandardComponentSupplier&datasets=sql/src/test/quidem/qatests/qaJsonCols/funcs_and_sql Review Comment: This change is wrong: the file name is `.msq.iq` which means it should be using `StandardMSQComponentSupplier`. ########## quidem-ut/src/test/quidem/org.apache.druid.quidem.QTest/qaArray/ops_funcs_mv_funcs.03.msq.iq: ########## @@ -9,10 +9,10 @@ FROM test_array; +-----+ | col | +-----+ -| 1 | -| 1 | | | | | +| 1 | +| 1 | Review Comment: This change, and the others in the file and in `qaArray/ops_funcs_mv_funcs.02.msq.iq`, look like improvements to me. The left-alignment of the values indicates they're now being treated as strings, which is more correct since these are `mv` functions. ########## quidem-ut/src/test/quidem/org.apache.druid.quidem.QTest/qaJsonCols/funcs_and_sql_func_json_value.03.dart.iq: ########## @@ -533,14 +533,14 @@ FROM test_json_cols; #------------------------------------------------------------------------- SELECT json_value(c1, '$.a_bool' RETURNING boolean) c FROM test_json_cols; -+-------+ Review Comment: The changes in this file look like improvements to me, since the values in the file are actually boolean `true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
