jtuglu1 commented on code in PR #18569:
URL: https://github.com/apache/druid/pull/18569#discussion_r2380815896
##########
sql/src/main/java/org/apache/druid/sql/http/SqlResource.java:
##########
@@ -97,7 +98,8 @@ public SqlResource(
final SqlEngineRegistry sqlEngineRegistry,
final SqlResourceQueryResultPusherFactory resultPusherFactory,
final DefaultQueryConfig defaultQueryConfig,
- final ServerConfig serverConfig
+ final ServerConfig serverConfig,
+ final QueryCountStatsProvider counter
Review Comment:
100% agree. Given that the behavior before this was `QueryResource` emitting
query count metrics only (SQL was just doing no-op, because these classes
didn't share any common class), do you think we can scope this PR to
refactoring both to share a single metrics counter instance? Then, a follow-up
can be adding the query execution type tag?
I think this change should address the core problem the GH issue mentions:
that SQL counts were not being tracked in `query/*/count` metrics. Then, adding
other ways of aggregating over these metrics with an extra dimension can be
added in a follow-up task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
