GWphua commented on issue #18446: URL: https://github.com/apache/druid/issues/18446#issuecomment-3358943430
I also see that you have rendered isLazyLoadOnStart() introduced in #6988 at `SegmentLocalCacheManager` obsolete by changing from the above to below: ``` final Segment segment = factory.factorize(dataSegment, segmentFiles, config.isLazyLoadOnStart(), loadFailed); --------- final Segment segment = factory.factorize(dataSegment, storageDir, false, lazyLoadCallback); ``` This PR seems like an enhanced version of #6988, where we will skip loading of ALL segments when the virtual storage mode is enabled. 1. I assume we can enable `isVirtualStorage` if `isLazyLoadOnStart` is enabled for backwards compatibility? 2. If we want to do a `lazyLoadOnStart` while choosing not to maintaining the old behaviour (historical only taking on segments that it can store), what will we do here? Set druid.server.maxSize == sum of druid.segmentCache.locations? Seeing the virtual storage functionality is an experimental feature, and the old `lazyLoadOnStart` isn't one, would it be OK to retain the previous `lazyLoadOnStart` feature instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
