clintropolis commented on code in PR #18628:
URL: https://github.com/apache/druid/pull/18628#discussion_r2427361255
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlBaseBenchmark.java:
##########
@@ -179,9 +182,10 @@ public enum BenchmarkStringEncodingStrategy
@Param({
"explicit",
- "auto"
+ "auto:none",
+ "auto:smile"
Review Comment:
I recommend splitting this out into separate parameter and adding an entry
to `checkIncompatibleParameters` and just pick one of the values to be the 'run
stuff' value and all others exit out (this is what we do for `stringEncoding`).
This is also better because this option only applies to `MMAP`, so can
similarly make sure the storageType is correct for this benchmark to make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
