GWphua commented on code in PR #18637:
URL: https://github.com/apache/druid/pull/18637#discussion_r2435328041
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -831,7 +835,9 @@ public void mount(StorageLocation mountLocation) throws
SegmentLoadingException
}
final SegmentizerFactory factory = getSegmentFactory(storageDir);
- final Segment segment = factory.factorize(dataSegment, storageDir,
false, lazyLoadCallback);
+ @SuppressWarnings("ObjectEquality")
+ final boolean lazy = config.isLazyLoadOnStart() && lazyLoadCallback
!= SegmentLazyLoadFailCallback.NOOP;
Review Comment:
Previously the code does not seem to have `lazyLoadCallback !=
SegmentLazyLoadFailCallback.NOOP` condition... Is it guaranteed that
lazyLoadCallback is not NOOP when `isLazyLoadOnStart()` is configured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
