abhishekrb19 commented on code in PR #18662:
URL: https://github.com/apache/druid/pull/18662#discussion_r2441534056
##########
processing/src/main/java/org/apache/druid/java/util/common/lifecycle/Lifecycle.java:
##########
@@ -476,6 +478,12 @@ public void stop()
}
}
}
+
+ @Override
+ public String toString()
+ {
+ return o.getClass().getSimpleName();
Review Comment:
It might be worth differentiating them if the handlers are ever invoked
concurrently, in that case, we could include the object's hash code and update
the `AnnotationBasedHandler`'s `start()` and `stop()` methods too to include
that info for individual handlers. Since they’re executed sequentially, it
doesn’t matter much for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
