FrankChen021 commented on code in PR #18591:
URL: https://github.com/apache/druid/pull/18591#discussion_r2425110452
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -179,6 +189,24 @@ protected KubernetesWorkItem joinAsync(Task task)
}
}
+ private void syncCapacityWithDynamicConfig()
Review Comment:
using a separate thread to check is also a bad idea , it does not solve the
real problem here but increase the complexity.
the real problem here is that the config manager does not provide a
notification mechanism when it detects configuration changes.
If we look at the config manager implementation, it provides a method
`swapIfNew` to check and set new values. This is a place where we can add
notification.
I think we can add a new overridden `watch` method which accepts a
`Runnable` as callback.
This callback is kept in the internal `ConfigHolder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
