clintropolis commented on code in PR #18553:
URL: https://github.com/apache/druid/pull/18553#discussion_r2418103110
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -723,35 +724,15 @@ private static RowSignature computeOutputRowSignature(
}
}
- VirtualColumns getVirtualColumns(final boolean includeDimensions)
+ /**
+ * Returns the virtual columns required for a query. Does not necessarily
return all virtual columns from
+ * {@link #sourceRowSignature}, only the ones actually referenced (and any
that they depend on).
+ *
+ * @param includeDimensions whether to include virtual columns refered by
{@link Grouping#getDimensions()}
+ */
+ VirtualColumns computeVirtualColumns(final boolean includeDimensions)
{
- // 'sourceRowSignature' could provide a list of all defined virtual
columns while constructing a query, but we
- // still want to collect the set of VirtualColumns this way to ensure we
only add what is still being used after
- // the various transforms and optimizations
- Set<VirtualColumn> virtualColumns = new HashSet<>();
-
-
- // rewrite any "specialized" virtual column expressions as top level
virtual columns so that their native
- // implementation can be used instead of being composed as part of some
expression tree in an expresson virtual
- // column
- Set<String> specialized = new HashSet<>();
- final boolean forceExpressionVirtualColumns =
- plannerContext.getPlannerConfig().isForceExpressionVirtualColumns();
Review Comment:
it seems like this flag is no longer honored, should we push the config into
the virtual column registry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
