GabrielCWT commented on code in PR #18613:
URL: https://github.com/apache/druid/pull/18613#discussion_r2431825204
##########
server/src/main/java/org/apache/druid/discovery/DiscoveryDruidNode.java:
##########
@@ -65,20 +69,36 @@
*/
private final Map<String, DruidService> services = new HashMap<>();
+ /**
+ * Constructor for tests. In production, the @Inject constructor is used
instead.
+ */
+ @VisibleForTesting
+ public DiscoveryDruidNode(
+ DruidNode druidNode,
+ NodeRole nodeRole,
+ Map<String, DruidService> services,
+ DateTime startTime
+ )
+ {
+ this(druidNode, nodeRole, services, startTime,
JvmUtils.getRuntimeInfo().getAvailableProcessors(), JvmUtils.getTotalMemory());
Review Comment:
Fixed
##########
server/src/main/java/org/apache/druid/discovery/DiscoveryDruidNode.java:
##########
@@ -65,20 +69,36 @@
*/
private final Map<String, DruidService> services = new HashMap<>();
+ /**
+ * Constructor for tests. In production, the @Inject constructor is used
instead.
+ */
+ @VisibleForTesting
+ public DiscoveryDruidNode(
+ DruidNode druidNode,
+ NodeRole nodeRole,
+ Map<String, DruidService> services,
+ DateTime startTime
+ )
+ {
+ this(druidNode, nodeRole, services, startTime,
JvmUtils.getRuntimeInfo().getAvailableProcessors(), JvmUtils.getTotalMemory());
+ }
+
public DiscoveryDruidNode(
DruidNode druidNode,
NodeRole nodeRole,
Map<String, DruidService> services
)
{
- this(druidNode, nodeRole, services, DateTimes.nowUtc());
+ this(druidNode, nodeRole, services, DateTimes.nowUtc(),
JvmUtils.getRuntimeInfo().getAvailableProcessors(), JvmUtils.getTotalMemory());
Review Comment:
Fixed
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java:
##########
@@ -381,6 +382,8 @@
final List<DataSegment> realtimeSegments = ImmutableList.of(segment2,
segment4, segment5);
private final DateTime startTime = DateTimes.nowUtc();
+ private final long availableProcessors =
JvmUtils.getRuntimeInfo().getAvailableProcessors();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
