abhishekrb19 commented on code in PR #18639:
URL: https://github.com/apache/druid/pull/18639#discussion_r2434204001
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -760,13 +760,17 @@ public void onComplete(Result result)
return;
}
- boolean success = result.isSucceeded();
+ final int statusCode = result.getResponse().getStatus();
Review Comment:
On the router, I suppose this is fine especially as
`result.getResponse().getStatus()` would effectively translate to the same
error code as the underlying exception on the query/data nodes, if it’s of type
`DruidException`/`QueryException`?
Not a blocker for this PR, but I wonder if there are e2e embedded query
tests, where we can validate that the metrics emitted from these different
services are similar.
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -760,13 +760,17 @@ public void onComplete(Result result)
return;
}
- boolean success = result.isSucceeded();
+ final int statusCode = result.getResponse().getStatus();
Review Comment:
On the router, I suppose this is fine especially as
`result.getResponse().getStatus()` would effectively translate to the same
error code as the underlying exception on the downstream query/data nodes, if
it’s of type `DruidException`/`QueryException`?
Not a blocker for this PR, but I wonder if there are e2e embedded query
tests, where we can validate that the metrics emitted from these different
services are similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
