kfaraz commented on code in PR #18684:
URL: https://github.com/apache/druid/pull/18684#discussion_r2450787885
##########
processing/src/main/java/org/apache/druid/indexer/partitions/DynamicPartitionsSpec.java:
##########
@@ -50,10 +50,13 @@ public DynamicPartitionsSpec(
@JsonProperty("maxTotalRows") @Nullable Long maxTotalRows
)
{
- this.maxRowsPerSegment =
PartitionsSpec.isEffectivelyNull(maxRowsPerSegment)
+
+ this.maxRowsPerSegment =
PartitionsSpec.isEffectivelyNull(maxRowsPerSegment) || maxRowsPerSegment <= 0
Review Comment:
If the given value is negative, we should throw an `InvalidInput` exception
rather than defaulting to some other value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
