cryptoe commented on code in PR #18688:
URL: https://github.com/apache/druid/pull/18688#discussion_r2454480152
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/endpoint/BasicAuthorizerResource.java:
##########
@@ -610,6 +612,24 @@ public Response getCachedSerializedGroupMap(
return resourceHandler.getCachedGroupMappingMaps(authorizerName);
}
+ @GET
+ @Path("/db/{authorizerName}/history")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ResourceFilters(BasicSecurityResourceFilter.class)
+ public Response getAuthorizerUpdateHistory(
Review Comment:
It looks like the only caller for this resource is the embedded test.
Do we really need this API ?
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/endpoint/BasicAuthorizerResource.java:
##########
@@ -610,6 +612,24 @@ public Response getCachedSerializedGroupMap(
return resourceHandler.getCachedGroupMappingMaps(authorizerName);
}
+ @GET
+ @Path("/db/{authorizerName}/history")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ResourceFilters(BasicSecurityResourceFilter.class)
+ public Response getAuthorizerUpdateHistory(
Review Comment:
If you really feel strongly about having this API, I guess a revert PR
followed by a new patch for adding an API makes more sense no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
