capistrant commented on code in PR #18705:
URL: https://github.com/apache/druid/pull/18705#discussion_r2479492099
##########
processing/src/main/java/org/apache/druid/java/util/metrics/CgroupMemoryMonitor.java:
##########
@@ -58,11 +76,28 @@ public CgroupMemoryMonitor()
@Override
public boolean doMonitor(ServiceEmitter emitter)
+ {
+ if (isRunningOnCgroupsV2) {
+ return cgroupV2MemoryMonitor.doMonitor(emitter);
+ } else {
+ return doMonitorInternal(emitter, cgroupDiscoverer, dimensions,
MEMORY_USAGE_FILE, MEMORY_LIMIT_FILE, this);
+ }
+ }
+
+ public static boolean doMonitorInternal(
Review Comment:
short javadoc might be helpful to note that this is a static utility method
used by v1 and v2 monitor. I don't fully understand the "internal" part of the
name either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
