aho135 commented on code in PR #18689:
URL: https://github.com/apache/druid/pull/18689#discussion_r2488324724
##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java:
##########
@@ -277,7 +285,7 @@ public void setPushGateway(PushGateway pushGateway)
* This method is called periodically by the TTL scheduler when using the
'exporter' strategy with
* a configured flushPeriod.
*/
- private void cleanUpStaleMetrics()
+ protected void cleanUpStaleMetrics()
Review Comment:
Thanks for the review @abhishekrb19!
I added the `@VisibleForTesting` annotation, but I think we can just keep
the scope `protected` since it's only used in the test class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
