abhishekrb19 commented on code in PR #18718:
URL: https://github.com/apache/druid/pull/18718#discussion_r2495541753
##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/DimensionsAndCollector.java:
##########
@@ -76,6 +76,10 @@ public double[] getHistogramBuckets()
*/
public void resetLastUpdateTime(List<String> labelValues)
{
+ if (ttlSeconds == null) {
+ // Label tracking is only required if a metric TTL has been configured
Review Comment:
Could move this comment to the method's javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
