kgyrtkirk commented on code in PR #18712:
URL: https://github.com/apache/druid/pull/18712#discussion_r2502030678
##########
integration-tests/script/docker_build_containers.sh:
##########
@@ -34,7 +34,7 @@ else
11 | 17 | 21)
echo "Build druid-cluster with Java $DRUID_INTEGRATION_TEST_JVM_RUNTIME"
docker build -t druid/cluster \
- --build-arg
JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-slim-bullseye \
+ --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy \
Review Comment:
I think this should correctly be
```
--build-arg JDK_VERSION=${DRUID_INTEGRATION_TEST_JVM_RUNTIME}-jre-jammy \
```
the current value of that variable
(`DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy`) will be unset all the time.
this implicitly means that this build arg was unset all the time and
alternate jdk version checks were running the same jdk
my bad... `-` does separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
