clintropolis commented on a change in pull request #7185: Avoid many
unnecessary materializations of collections of 'all segments in cluster'
cardinality
URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262811572
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -429,30 +447,9 @@ public void moveSegment(
}
}
- public Set<DataSegment> getOrderedAvailableDataSegments()
+ public Iterable<DataSegment> iterateAvailableDataSegments()
Review comment:
nit: same comment re naming, maybe `getAvailableSegmentsIterable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
