kfaraz commented on code in PR #18743:
URL: https://github.com/apache/druid/pull/18743#discussion_r2532624341
##########
server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorTest.java:
##########
@@ -2546,6 +2546,65 @@ public void
test_dropSegment_skipsUnlockInterval_ifOverlappingSinkIsActive() thr
}
}
+ /**
+ * Tests an edge case where a writable sink exists but has no hydrants.
+ * <p>
+ * The test scenario is somewhat unrealistic, but we are trying to prevent a
regression because this issue was seen in
+ * the wild and resulted in failed indexing tasks due to an IAE.
+ * </p>
+ */
Review Comment:
I think the javadoc here can be omitted.
Also, since it was already reported, I think it is a valid scenario.
##########
server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorTest.java:
##########
@@ -2546,6 +2546,65 @@ public void
test_dropSegment_skipsUnlockInterval_ifOverlappingSinkIsActive() thr
}
}
+ /**
+ * Tests an edge case where a writable sink exists but has no hydrants.
+ * <p>
+ * The test scenario is somewhat unrealistic, but we are trying to prevent a
regression because this issue was seen in
+ * the wild and resulted in failed indexing tasks due to an IAE.
+ * </p>
+ */
+ @Test
+ public void testPersistAllWithEmptySink() throws Exception
Review Comment:
Nit: update the method name to reflect the expected behaviour with the
suffix `IsNoop` or `DoesNotFail`, etc.
```suggestion
public void testPersistAllWithEmptySinkIsNoop() throws Exception
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
