kfaraz commented on code in PR #18760:
URL: https://github.com/apache/druid/pull/18760#discussion_r2545498555
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -466,13 +465,13 @@ public boolean isPerfectRollup()
* Checks if multi-valued string dimensions need to be analyzed by
downloading the segments.
* This method returns true only for MSQ engine when either of the following
holds true:
* <ul>
- * <li> Range partitioning is done on a string dimension or an unknown
dimension
+ * <li> Range partitioning is done on a possibly multi-valued string
dimension or an unknown dimension
* (since MSQ does not support partitioning on a multi-valued string
dimension) </li>
* <li> Rollup is done on a string dimension or an unknown dimension
Review Comment:
```suggestion
* <li> Rollup is done on a possibly multi-valued string dimension or an
unknown dimension
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
