kfaraz commented on code in PR #18774:
URL: https://github.com/apache/druid/pull/18774#discussion_r2553831095
##########
processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java:
##########
@@ -176,14 +176,20 @@ public Set<ObjectType>
findNonOvershadowedObjectsInInterval(Interval interval, P
.toSet();
}
+ /**
+ * Add a single partition chunk entry to this timeline. Avoid calling this
in a loop, since it
+ * is O(objects in holder) and can therefore creates O(N^2) situations.
Instead use {@link #addAll(Iterator)}
Review Comment:
May be also link to `PartitionHolder.isComplete()` in this javadoc since
that is really the RDS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
