github-advanced-security[bot] commented on code in PR #18790:
URL: https://github.com/apache/druid/pull/18790#discussion_r2575122489
##########
server/src/test/java/org/apache/druid/server/QueryStackTests.java:
##########
@@ -365,10 +376,23 @@
return conglomerate;
}
+ /**
+ * @deprecated The minTopNThreshold parameter is no longer used. Use query
context to set minTopNThreshold.
+ */
+ @Deprecated
+ public static QueryRunnerFactoryConglomerate
createQueryRunnerFactoryConglomerate(
+ final DruidProcessingConfig processingConfig,
+ final Integer minTopNThreshold,
Review Comment:
## Useless parameter
The parameter 'minTopNThreshold' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10571)
##########
server/src/test/java/org/apache/druid/server/QueryStackTests.java:
##########
@@ -272,25 +272,28 @@
* Returns a new {@link QueryRunnerFactoryConglomerate}. Adds relevant
closeables to the passed-in {@link Closer}.
*/
public static QueryRunnerFactoryConglomerate
createQueryRunnerFactoryConglomerate(final Closer closer)
- {
- return createQueryRunnerFactoryConglomerate(closer,
TopNQueryConfig.DEFAULT_MIN_TOPN_THRESHOLD);
- }
-
- public static QueryRunnerFactoryConglomerate
createQueryRunnerFactoryConglomerate(
- final Closer closer,
- final Integer minTopNThreshold
- )
{
return createQueryRunnerFactoryConglomerate(
closer,
getProcessingConfig(
DEFAULT_NUM_MERGE_BUFFERS
),
- minTopNThreshold,
TestHelper.makeJsonMapper()
);
}
+ /**
+ * @deprecated The minTopNThreshold parameter is no longer used. Use query
context to set minTopNThreshold.
+ */
+ @Deprecated
+ public static QueryRunnerFactoryConglomerate
createQueryRunnerFactoryConglomerate(
+ final Closer closer,
+ final Integer minTopNThreshold
Review Comment:
## Useless parameter
The parameter 'minTopNThreshold' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10572)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
