cryptoe commented on code in PR #18787:
URL: https://github.com/apache/druid/pull/18787#discussion_r2575777329
##########
multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java:
##########
@@ -717,40 +717,57 @@ private static TaskStatus runSubtasks(
final int totalNumSpecs = tasks.size();
log.info("Generated [%d] MSQControllerTask specs", totalNumSpecs);
+ TaskStatus firstFailure = null;
int failCnt = 0;
- for (MSQControllerTask eachTask : tasks) {
- final String json =
toolbox.getJsonMapper().writerWithDefaultPrettyPrinter().writeValueAsString(eachTask);
- if (!currentSubTaskHolder.setTask(eachTask)) {
+ for (int taskCnt = 0; taskCnt < tasks.size(); taskCnt++) {
+ final MSQControllerTask task = tasks.get(taskCnt);
+ final String json =
toolbox.getJsonMapper().writerWithDefaultPrettyPrinter().writeValueAsString(task);
+ if (!currentSubTaskHolder.setTask(task)) {
String errMsg = "Task was asked to stop. Finish as failed.";
- log.info(errMsg);
+ log.info("%s", errMsg);
return TaskStatus.failure(compactionTaskId, errMsg);
}
try {
- if (eachTask.isReady(toolbox.getTaskActionClient())) {
- log.info("Running MSQControllerTask: " + json);
- final TaskStatus eachResult = eachTask.run(toolbox);
- if (!eachResult.isSuccess()) {
+ if (task.isReady(toolbox.getTaskActionClient())) {
+ log.info("Running MSQControllerTask[%d]: %s", taskCnt, json);
+ final TaskStatus taskStatus = task.run(toolbox);
+ if (!taskStatus.isSuccess()) {
failCnt++;
- log.warn("Failed to run MSQControllerTask: [%s].\nTrying the next
MSQControllerTask.", json);
+ log.warn("Failed to run MSQControllerTask[%d]: %s", taskCnt,
taskStatus.getErrorMsg());
Review Comment:
Similar task number comment here.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java:
##########
@@ -717,40 +717,57 @@ private static TaskStatus runSubtasks(
final int totalNumSpecs = tasks.size();
log.info("Generated [%d] MSQControllerTask specs", totalNumSpecs);
+ TaskStatus firstFailure = null;
int failCnt = 0;
- for (MSQControllerTask eachTask : tasks) {
- final String json =
toolbox.getJsonMapper().writerWithDefaultPrettyPrinter().writeValueAsString(eachTask);
- if (!currentSubTaskHolder.setTask(eachTask)) {
+ for (int taskCnt = 0; taskCnt < tasks.size(); taskCnt++) {
+ final MSQControllerTask task = tasks.get(taskCnt);
+ final String json =
toolbox.getJsonMapper().writerWithDefaultPrettyPrinter().writeValueAsString(task);
+ if (!currentSubTaskHolder.setTask(task)) {
String errMsg = "Task was asked to stop. Finish as failed.";
- log.info(errMsg);
+ log.info("%s", errMsg);
return TaskStatus.failure(compactionTaskId, errMsg);
}
try {
- if (eachTask.isReady(toolbox.getTaskActionClient())) {
- log.info("Running MSQControllerTask: " + json);
- final TaskStatus eachResult = eachTask.run(toolbox);
- if (!eachResult.isSuccess()) {
+ if (task.isReady(toolbox.getTaskActionClient())) {
+ log.info("Running MSQControllerTask[%d]: %s", taskCnt, json);
Review Comment:
Nit: It seems kind of weird that the MSQControllerTask[%d] is not the the
task id but the taskcnt.
Should be rename this to something like
"Running MSQCompaction task number[%d] with payload : %s"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
