Fly-Style commented on code in PR #18786: URL: https://github.com/apache/druid/pull/18786#discussion_r2577820125
########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryErrorTest.java: ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.query; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.druid.client.broker.BrokerClient; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.query.Druids; +import org.apache.druid.query.QueryContexts; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.rpc.HttpResponseException; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.FieldSource; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_CAPACITY_EXCEEDED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_FAILURE_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_TIMEOUT_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_UNSUPPORTED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.RESOURCE_LIMIT_EXCEEDED_TEST_CONTEXT_KEY; + +/** + * This class tests various query failures. + * <p> + * - SQL planning failures. Both {@link org.apache.calcite.sql.parser.SqlParseException} + * and {@link org.apache.calcite.tools.ValidationException} are tested using SQLs that must fail. + * - Various query errors from historicals. These tests use {@link ServerManagerForQueryErrorTest} to make + * the query to always throw an exception. + */ +public class QueryErrorTest extends QueryTestBase +{ + // TODO: introduce onAnyRouter(...) and use it; add TLS tests in the follow-up patches + protected static List<Boolean> SHOULD_USE_SQL_ENGINE = List.of(true, false); + + @Override + protected EmbeddedDruidCluster createCluster() + { + overlord.addProperty("druid.manager.segments.pollDuration", "PT0.1s"); + indexer.setServerMemory(600_000_000) + .addProperty("druid.worker.capacity", "4") + .addProperty("druid.processing.numThreads", "2") + .addProperty("druid.segment.handoff.pollDuration", "PT0.1s"); + + return EmbeddedDruidCluster.withEmbeddedDerbyAndZookeeper() + .useLatchableEmitter() + .addServer(overlord) + .addServer(coordinator) + .addServer(broker) + .addServer(router) + .addServer(indexer) + .addServer(historical) + .addExtension(ServerManagerForQueryErrorTestModule.class); + } + + @Override + protected void beforeAll() + { + var ingestionStatus = cluster.callApi().onAnyBroker( + b -> b.submitSqlTask( + new ClientSqlQuery( + "REPLACE INTO t\n" + + "OVERWRITE ALL\n" + + "SELECT CURRENT_TIMESTAMP AS __time, 1 AS d\n" + + "PARTITIONED BY ALL", + null, + false, + false, + false, + Map.of(), + List.of() + ) + ) + ); + cluster.callApi().waitForTaskToSucceed(ingestionStatus.getTaskId(), overlord); + try { + Thread.sleep(1000L); + } + catch (InterruptedException e) { + throw new AssertionError(e); + } + } + + @Test + public void testSqlParseException() + { + MatcherAssert.assertThat( + Assertions.assertThrows( + Exception.class, + () -> cluster.callApi().onAnyBroker( + b -> b.submitSqlQuery( + new ClientSqlQuery( + "count(*) FROM t", + null, + false, + false, + false, + Map.of(), + List.of() + ) + ) + ) + ), + ExceptionMatcher.of(HttpResponseException.class) + .expectMessageContains("400 Bad Request") + ); + } + + @Test + public void testSqlValidationException() + { + MatcherAssert.assertThat( + Assertions.assertThrows( + Exception.class, + () -> cluster.callApi().onAnyBroker( Review Comment: Addressed in https://github.com/apache/druid/pull/18786/commits/0d5cde4236e9d85cd6f4fb52e505a5698bcae531 ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryErrorTest.java: ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.query; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.druid.client.broker.BrokerClient; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.query.Druids; +import org.apache.druid.query.QueryContexts; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.rpc.HttpResponseException; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.FieldSource; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_CAPACITY_EXCEEDED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_FAILURE_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_TIMEOUT_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_UNSUPPORTED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.RESOURCE_LIMIT_EXCEEDED_TEST_CONTEXT_KEY; + +/** + * This class tests various query failures. + * <p> + * - SQL planning failures. Both {@link org.apache.calcite.sql.parser.SqlParseException} + * and {@link org.apache.calcite.tools.ValidationException} are tested using SQLs that must fail. + * - Various query errors from historicals. These tests use {@link ServerManagerForQueryErrorTest} to make + * the query to always throw an exception. + */ +public class QueryErrorTest extends QueryTestBase +{ + // TODO: introduce onAnyRouter(...) and use it; add TLS tests in the follow-up patches + protected static List<Boolean> SHOULD_USE_SQL_ENGINE = List.of(true, false); + + @Override + protected EmbeddedDruidCluster createCluster() + { + overlord.addProperty("druid.manager.segments.pollDuration", "PT0.1s"); + indexer.setServerMemory(600_000_000) + .addProperty("druid.worker.capacity", "4") + .addProperty("druid.processing.numThreads", "2") + .addProperty("druid.segment.handoff.pollDuration", "PT0.1s"); + + return EmbeddedDruidCluster.withEmbeddedDerbyAndZookeeper() + .useLatchableEmitter() + .addServer(overlord) + .addServer(coordinator) + .addServer(broker) + .addServer(router) + .addServer(indexer) + .addServer(historical) + .addExtension(ServerManagerForQueryErrorTestModule.class); + } + + @Override + protected void beforeAll() + { + var ingestionStatus = cluster.callApi().onAnyBroker( + b -> b.submitSqlTask( + new ClientSqlQuery( + "REPLACE INTO t\n" + + "OVERWRITE ALL\n" + + "SELECT CURRENT_TIMESTAMP AS __time, 1 AS d\n" + + "PARTITIONED BY ALL", + null, + false, + false, + false, + Map.of(), + List.of() + ) + ) + ); + cluster.callApi().waitForTaskToSucceed(ingestionStatus.getTaskId(), overlord); + try { + Thread.sleep(1000L); Review Comment: https://github.com/apache/druid/pull/18786/commits/0d5cde4236e9d85cd6f4fb52e505a5698bcae531 ########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryErrorTest.java: ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.query; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.druid.client.broker.BrokerClient; +import org.apache.druid.error.ExceptionMatcher; +import org.apache.druid.query.Druids; +import org.apache.druid.query.QueryContexts; +import org.apache.druid.query.http.ClientSqlQuery; +import org.apache.druid.rpc.HttpResponseException; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.hamcrest.MatcherAssert; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.FieldSource; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_CAPACITY_EXCEEDED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_FAILURE_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_TIMEOUT_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.QUERY_UNSUPPORTED_TEST_CONTEXT_KEY; +import static org.apache.druid.testing.embedded.query.ServerManagerForQueryErrorTest.RESOURCE_LIMIT_EXCEEDED_TEST_CONTEXT_KEY; + +/** + * This class tests various query failures. + * <p> + * - SQL planning failures. Both {@link org.apache.calcite.sql.parser.SqlParseException} + * and {@link org.apache.calcite.tools.ValidationException} are tested using SQLs that must fail. + * - Various query errors from historicals. These tests use {@link ServerManagerForQueryErrorTest} to make + * the query to always throw an exception. + */ +public class QueryErrorTest extends QueryTestBase +{ + // TODO: introduce onAnyRouter(...) and use it; add TLS tests in the follow-up patches + protected static List<Boolean> SHOULD_USE_SQL_ENGINE = List.of(true, false); + + @Override + protected EmbeddedDruidCluster createCluster() + { + overlord.addProperty("druid.manager.segments.pollDuration", "PT0.1s"); + indexer.setServerMemory(600_000_000) + .addProperty("druid.worker.capacity", "4") + .addProperty("druid.processing.numThreads", "2") + .addProperty("druid.segment.handoff.pollDuration", "PT0.1s"); + + return EmbeddedDruidCluster.withEmbeddedDerbyAndZookeeper() + .useLatchableEmitter() + .addServer(overlord) + .addServer(coordinator) + .addServer(broker) + .addServer(router) + .addServer(indexer) + .addServer(historical) + .addExtension(ServerManagerForQueryErrorTestModule.class); + } + + @Override + protected void beforeAll() + { + var ingestionStatus = cluster.callApi().onAnyBroker( Review Comment: https://github.com/apache/druid/pull/18786/commits/0d5cde4236e9d85cd6f4fb52e505a5698bcae531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
