abhishekrb19 opened a new pull request, #18793: URL: https://github.com/apache/druid/pull/18793
- The existing tests in `CliPeon` use the default Node, which will end up loading all modules applicable generally for all servers. This patch tightens the behavior by adding only the Peon role specifically for CliPeonTest. - Remove `FakeCliPeon`, which was a bit hacky that was used to manipulate private fields in `CliPeon` through reflection and add a system property. This wasn't really necessary as we can just leverage `CliPeon` and `Properties`. This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
