clintropolis commented on code in PR #18831:
URL: https://github.com/apache/druid/pull/18831#discussion_r2608965762
##########
embedded-tests/pom.xml:
##########
@@ -29,6 +29,7 @@
<properties>
<surefire.rerunFailingTestsCount>0</surefire.rerunFailingTestsCount>
+ <maven.compiler.release>17</maven.compiler.release>
Review Comment:
we will also need to remember to remove the changes here and in
static-checks.yml in the future, not sure how to best manage that debt, i guess
we could put a note in the root pom.xml...
imo we should try to avoid diverging like this in any other modules and try
to stay consistent with the root pom unless there is a seriously good reason so
that we don't have to keep track of stuff like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
